From 096d061b99078b3a89181d6841f0c01a1eec0017 Mon Sep 17 00:00:00 2001 From: NeilBrown Date: Sat, 18 Dec 2021 20:46:27 +1100 Subject: [PATCH] oceani: remove the last of the UNTESTED - for now. I think there are more lines that aren't being tested though... Signed-off-by: NeilBrown --- csrc/oceani-tests.mdc | 2 +- csrc/oceani.mdc | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/csrc/oceani-tests.mdc b/csrc/oceani-tests.mdc index e502822..45240a2 100644 --- a/csrc/oceani-tests.mdc +++ b/csrc/oceani-tests.mdc @@ -97,7 +97,7 @@ arguments separated from the name by commas. For each test, there is a section ## valgrind test code @[ -n "$$SKIP_COVERAGE_CHECK" ] || awk '/NOTEST/ { next } /^ *[1-9]/ {ran+=1} /^ *###/ {skip+=1} \ END {printf "coverage: %6.2f%%\n", ran * 100 / (ran + skip); \ - if (ran < (ran + skip) *0.98) exit(1) }' \ + if (ran < (ran + skip) *0.99) exit(1) }' \ coverage/oceani.mdc.gcov coverage_oceani: oceani.c diff --git a/csrc/oceani.mdc b/csrc/oceani.mdc index 2f3c973..ca59924 100644 --- a/csrc/oceani.mdc +++ b/csrc/oceani.mdc @@ -2398,16 +2398,16 @@ with a const size by whether they are prepared at parse time or not. struct value *vsize; mpz_t q; if (type->array.static_size) - return 1; // UNTESTED + return 1; // NOTEST - guard against reentry if (type->array.unspec && parse_time) - return 1; // UNTESTED + return 1; // NOTEST - unspec is still incomplete if (parse_time && type->array.vsize && !type->array.vsize->global) - return 1; // UNTESTED + return 1; // NOTEST - should be impossible if (type->array.vsize) { vsize = var_value(c, type->array.vsize); if (!vsize) - return 1; // UNTESTED + return 1; // NOTEST - should be impossible mpz_init(q); mpz_tdiv_q(q, mpq_numref(vsize->num), mpq_denref(vsize->num)); type->array.size = mpz_get_si(q); @@ -2416,7 +2416,7 @@ with a const size by whether they are prepared at parse time or not. if (!parse_time) return 1; if (type->array.member->size <= 0) - return 0; // UNTESTED + return 0; // NOTEST - error caught before here type->array.static_size = 1; type->size = type->array.size * type->array.member->size; @@ -3387,7 +3387,7 @@ anything in the heap or on the stack. A reference can be assigned case AddressOf: /* left must be lval, we create reference to it */ if (!type || type->free != reference_free) - t = propagate_types(b->left, c, perr, type, 0); // UNTESTED + t = propagate_types(b->left, c, perr, type, 0); // NOTEST impossible else t = propagate_types(b->left, c, perr, type->reference.referent, 0); -- 2.43.0