From c5918479743e3b8e1bf83851121b9e44b2d8a5a4 Mon Sep 17 00:00:00 2001 From: NeilBrown Date: Sun, 12 Dec 2021 09:43:41 +1100 Subject: [PATCH] oceani: replace some magic numbers with an enum. I'm growing to dislike magic numbers Signed-off-by: NeilBrown --- csrc/oceani.mdc | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/csrc/oceani.mdc b/csrc/oceani.mdc index 12be60c..178532c 100644 --- a/csrc/oceani.mdc +++ b/csrc/oceani.mdc @@ -2742,6 +2742,7 @@ function will be needed. int index; struct text name; }; + enum { IndexUnknown = -1, IndexInvalid = -2 }; ###### free exec cases case Xfieldref: @@ -2758,7 +2759,7 @@ function will be needed. struct fieldref *fr = new_pos(fieldref, $2); fr->left = $<1; fr->name = $3.txt; - fr->index = -2; + fr->index = IndexUnknown; $0 = fr; } }$ @@ -2779,7 +2780,7 @@ function will be needed. for (i = 0; i < type->structure.nfields; i++) if (text_cmp(type->structure.fields[i].name, field) == 0) return i; - return -1; + return IndexInvalid; } ###### propagate exec cases @@ -2795,7 +2796,7 @@ function will be needed. else if (st->init != structure_init) type_err(c, "error: field reference attempted on %1, not a struct", f->left, st, 0, NULL); - else if (f->index == -2) { + else if (f->index == IndexUnknown) { f->index = find_struct_index(st, f->name); if (f->index < 0) type_err(c, "error: cannot find requested field in %1", -- 2.43.0