]> ocean-lang.org Git - ocean/commitdiff
oceani: simplify test in var_block_close.
authorNeilBrown <neil@brown.name>
Fri, 5 Nov 2021 23:30:34 +0000 (10:30 +1100)
committerNeilBrown <neil@brown.name>
Mon, 8 Nov 2021 09:56:36 +0000 (20:56 +1100)
v->depth is never less than v->min_depth, so checking that
both exceed ->scope_depth is pointless, only test ->min_depth.

Signed-off-by: NeilBrown <neil@brown.name>
csrc/oceani-tests.mdc
csrc/oceani.mdc

index 8eebb8c3f6757d4472889f0128db1dd9e75429ff..973331fbddb67baf77e17ed8ddec4ab21809a93c 100644 (file)
@@ -80,7 +80,7 @@ arguments separated from the name by commas.  For each test, there is a section
                @mv *.gcov coverage ; [ -f .gcov ] && mv .gcov coverage || true
                @ awk '/NOTEST/ { next } /^ *[1-9]/ {ran+=1} /^ *###/ {skip+=1} \
                    END {printf "coverage: %6.2f%%\n", ran * 100 / (ran + skip); \
                @mv *.gcov coverage ; [ -f .gcov ] && mv .gcov coverage || true
                @ awk '/NOTEST/ { next } /^ *[1-9]/ {ran+=1} /^ *###/ {skip+=1} \
                    END {printf "coverage: %6.2f%%\n", ran * 100 / (ran + skip); \
-                        if (ran < (ran + skip) *0.95) exit(1) }' \
+                        if (ran < (ran + skip) *0.948) exit(1) }' \
                        coverage/oceani.mdc.gcov
                @rm -f .tmp*
 
                        coverage/oceani.mdc.gcov
                @rm -f .tmp*
 
index 1dd320f1b5f1a03bfa3196d96b59ca6d62760846..4bd3959f5147ac5bdcab4f1d46760f5cbc60fcec 100644 (file)
@@ -1147,7 +1147,7 @@ all pending-scope variables become conditionally scoped.
 
                scope_pop(c);
                for (vp = &c->in_scope;
 
                scope_pop(c);
                for (vp = &c->in_scope;
-                    v = *vp, v && v->depth > c->scope_depth && v->min_depth > c->scope_depth;
+                    v = *vp, v && v->min_depth > c->scope_depth;
                     ) {
                        if (v->name->var == v) switch (ct) {
                        case CloseElse:
                     ) {
                        if (v->name->var == v) switch (ct) {
                        case CloseElse: